[ci-visibility] Fix random cypress integration tests timeouts #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.36 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3255 +/- ##
=======================================
Coverage 86.02% 86.03%
=======================================
Files 194 194
Lines 7514 7517 +3
Branches 33 33
=======================================
+ Hits 6464 6467 +3
Misses 1050 1050 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juan-fernandez
commented
Jun 19, 2023
| webAppPort = await getPort() | ||
| webAppServer.listen(webAppPort) | ||
| }) | ||
| function getCypressVersion () { |
There was a problem hiding this comment.
the cypress version to install now comes as an env var from the CI job, this way we can more easily parallelise.
rochdev
approved these changes
Jun 19, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are occasional timeouts for cypress tests. This PR:
childProcess.on('exit')and addsdonein there. I'm not sure why, but not handling the exit of the process seems to leave node hanging.Motivation
Keep CI fast and green. I've run the integration tests job 10 times and it seems flakiness is gone (at least potentially): https://github.com/DataDog/dd-trace-js/actions/runs/5313741276